[#53] Fixed type mismatch when providing show-run-dates argument to ts:list#54
Open
marcin-jozwikowski wants to merge 1 commit into
Open
Conversation
NicoHaase
reviewed
Jun 25, 2026
|
|
||
| $application = new Application(); | ||
| /** @var Scheduler $scheduler */ | ||
| $application->add(new ListCommand($scheduler)); |
Collaborator
There was a problem hiding this comment.
Can you change this to the following? Since today, the package also supports Symfony 8, and Application::add has been removed
$application->addCommands([new ListCommand($scheduler)]);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple fix to type mismatch described in issue #53 : introduce a type cast to int.
Added a test to simulate the behaviour that caused the problem. It randomizes the argument to avoid hard-coded false-positives; passes the value as a string to the command; and finally expects everything to work just fine.