Add search messages and schema updates#26
Conversation
* Add an endpoint for Bob * Repository returns all recipients with same name
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the chat application's app functions by renaming the message sending function to sendMessage (returning a simple string), updating ContactSearchResult with more descriptive fields, and introducing a new searchMessages function along with its corresponding data models and tests. The review feedback suggests validating against empty queries in searchMessages to prevent performance and privacy issues, querying messages concurrently rather than sequentially, and optimizing searchRecipients by applying take(maxCount) before mapping the elements when the query is blank.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
We have made some updates to the repository and build files. Please resolve the merge conflicts so we can get this onto main. |
44e96d5 to
d843bc9
Compare
|
Conflicts merged, PTAL |
| throw AppFunctionAppUnknownException("Failed to send message: ${e.message}") | ||
| } | ||
|
|
||
| return Result(sentMessageId, "Message sent to: $displayName.") |
There was a problem hiding this comment.
Why are you removing the message Id at this point?
| endpointValue = id, | ||
| messages = | ||
| matchingMessages.map { | ||
| val senderDisplayName = |
There was a problem hiding this comment.
How about a helper function for setting the display name?
2 participants
Added app function to search messages.
Update schema with some nit renames.