Skip to content

fix(@angular/cli): remove algoliasearch dependency and support latest docs versions#33594

Merged
clydin merged 1 commit into
angular:mainfrom
clydin:fix/cli-remove-algoliasearch
Jul 20, 2026
Merged

fix(@angular/cli): remove algoliasearch dependency and support latest docs versions#33594
clydin merged 1 commit into
angular:mainfrom
clydin:fix/cli-remove-algoliasearch

Conversation

@clydin

@clydin clydin commented Jul 17, 2026

Copy link
Copy Markdown
Member

Eliminate the client library dependency on algoliasearch by replacing the Algolia query calls with native fetch requests. This removes 15 transitively installed npm packages from the CLI dependencies. Also, bump LATEST_KNOWN_DOCS_VERSION to 22 and add a unit test suite to verify the documentation search and fallback version logic.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the dependency on the algoliasearch package and refactors the documentation search tool to perform direct HTTP fetch requests to the Algolia API. It also updates the latest known documentation version to 22 and introduces comprehensive unit tests. The review feedback recommends adding a timeout to the fetch request to prevent hanging, improving error messages by including the HTTP status code, and utilizing the available logger to record search errors instead of silently catching them.

Comment thread packages/angular/cli/src/commands/mcp/tools/doc-search.ts
Comment thread packages/angular/cli/src/commands/mcp/tools/doc-search.ts
Comment thread packages/angular/cli/src/commands/mcp/tools/doc-search.ts
@clydin
clydin force-pushed the fix/cli-remove-algoliasearch branch from 740fd90 to 4baa6e4 Compare July 17, 2026 01:35
@clydin clydin added target: minor This PR is targeted for the next minor release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 17, 2026
@clydin clydin linked an issue Jul 17, 2026 that may be closed by this pull request
… docs versions

Eliminate the client library dependency on `algoliasearch` by replacing the Algolia query calls with native `fetch` requests. This removes 15 transitively installed npm packages from the CLI dependencies.
Also, bump `LATEST_KNOWN_DOCS_VERSION` to 22 and add a unit test suite to verify the documentation search and fallback version logic.
@clydin
clydin force-pushed the fix/cli-remove-algoliasearch branch from 4baa6e4 to b6c5f5b Compare July 20, 2026 13:04
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 20, 2026
@clydin
clydin merged commit c963ecb into angular:main Jul 20, 2026
40 checks passed
@clydin

clydin commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

@clydin
clydin deleted the fix/cli-remove-algoliasearch branch July 20, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/cli target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Algolia packages and version support

2 participants