fix(@angular/build): ensure import map integrity keys are valid URL-like specifiers#33618
Merged
Merged
Conversation
alan-agius4
added
the
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request ensures that subresource integrity (SRI) importmap keys are formatted as valid URL-like specifiers by prepending ./ to relative paths that do not start with a dot or slash. While the implementation and accompanying tests are solid, the regular expression used to identify resolvable URLs is too permissive and will incorrectly match filenames starting with 'http' or 'https' (e.g., 'http-client.js'). It is recommended to update the regex to require '://' after the protocol to prevent this issue.
alan-agius4
force-pushed
the
fix-sri-importmap-keys
branch
from
July 21, 2026 09:33
46e142c to
7b1b8df
Compare
alan-agius4
added
the
action: review
…ike specifiers In import maps, the keys for the integrity map must be valid URL-like specifiers (either absolute URLs, or relative URLs starting with /, ./, or ../). If a key is a bare filename like chunk-SYbG1sRo.js, the browser ignores it with a warning. We now prepend ./ to relative paths in the integrity map keys if they do not start with a slash, dot-slash, or protocol, resolving browser warning issues when subresource integrity is enabled for dynamically loaded chunks. Fixes angular#33617
alan-agius4
force-pushed
the
fix-sri-importmap-keys
branch
from
July 21, 2026 09:38
7b1b8df to
2b48db4
Compare
clydin
approved these changes
Jul 21, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In import maps, the keys for the integrity map must be valid URL-like specifiers (either absolute URLs, or relative URLs starting with /, ./, or ../). If a key is a bare filename like chunk-SYbG1sRo.js, the browser ignores it with a warning.
We now prepend ./ to relative paths in the integrity map keys if they do not start with a slash, dot-slash, or protocol, resolving browser warning issues when subresource integrity is enabled for dynamically loaded chunks.
Fixes #33617