fix(opencode): scope rtk permission patterns#29338
Open
YOMXXX wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29311
Type of change
What does this PR do?
The bash permission arity dictionary did not know about
rtk, so an always-allow decision for commands such asrtk env PATHorrtk git clone ...collapsed tortk *. That pattern is broader than the command the user approved.This PR adds
rtkarity entries for the wrapper's top-level and nested subcommands, including git, docker compose, telemetry, hook, package manager, and language/tool wrappers. The added regression test confirmsrtk env *,rtk git clone *,rtk docker compose logs *, andrtk telemetry status *style prefixes are produced.How did you verify your code works?
cd packages/opencode && PATH="$HOME/.bun/bin:$PATH" bun test test/permission/arity.test.tscd packages/opencode && PATH="$HOME/.bun/bin:$PATH" bun typecheckgit diff --checkPATH="$HOME/.bun/bin:$PATH" .husky/pre-pushScreenshots / recordings
Not applicable; permission pattern generation only.
Checklist