fix(core/markdown): compact tight nested lists#1109
Open
kitlangton wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internalBlockMode: "top-level"andstreaming: trueconfiguration.textchildren as well as loose-listparagraphchildren.Why #1094 Did Not Cover This
#1094 fixed the blank-row symptom for a loose nested list whose source contains a blank line before its child list. Marked represents that parent content as a
paragraphtoken.This reproducer uses a tight nested list with no source blank line. Marked represents the same parent-content position as a
texttoken. The existing normalization applied only toparagraph, leaving the trailing newline ontextand producing an empty rendered row before each nested list.Before
After
R/G/R Verification
2b03ee50adds only the regression test; againstv0.2.15it fails with six inserted blank rows matching the Before output.3833b39dapplies the minimal normalization fix.fec798d4removesgetListChildMarkdownRaw, which no longer carries distinct behavior after both textual child token shapes normalize identically.bun test src/renderables/__tests__/Markdown.test.tson the runnablev0.2.15worktree:138 pass, 0 fail.bun run fmt:check packages/core/src/renderables/Markdown.ts packages/core/src/renderables/__tests__/Markdown.test.tspasses.The
v0.2.15validation seam is intentional: it is the shipped OpenTUI version currently consumed by OpenCode. Currentmainhas an unreleased native ABI change (getRenderStats) that prevents running the TypeScript renderer suite against the published0.2.15dylib in a clean worktree.