fix: Rename parquet feature flag 'flate2-rust_backened' to 'flate2-rust_backend'#10239
Open
dannycjones wants to merge 1 commit into
Open
fix: Rename parquet feature flag 'flate2-rust_backened' to 'flate2-rust_backend'#10239dannycjones wants to merge 1 commit into
dannycjones wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
rust_backenedis misspelled #9031.Rationale for this change
The original feature flag was misspelt. We should update it to use the correct spelling and maintain an alias until a breaking release is made.
There is no warning introduced yet for the removal of the old feature flag. It could be added using a build script, however I believe that adds unnecessary overhead when we have no other use for build scripts at this time in the
parquetcrate.What changes are included in this PR?
This change renames the feature flag including all code references. It also maintains an alias such that existing users aren't broken but the new feature flag can be adopted.
Are these changes tested?
This change relies on existing CI tests.
Are there any user-facing changes?
Yes, the feature flag is updated. To my knowledge, I've updated all references to it.