Skip to content

ui: show selected template hypervisor in deploy form - #13813

Open
Dogface2k wants to merge 1 commit into
apache:4.22from
Dogface2k:fix/issue-13786-hypervisor-label
Open

ui: show selected template hypervisor in deploy form#13813
Dogface2k wants to merge 1 commit into
apache:4.22from
Dogface2k:fix/issue-13786-hypervisor-label

Conversation

@Dogface2k

@Dogface2k Dogface2k commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #13786.

Selecting a template could leave the Deploy VM form using the initial zone hypervisor. The displayed hypervisor and related form state could therefore be incorrect when the selected template used a different hypervisor.

The deploy form now follows the hypervisor metadata of the selected template.

Changes

  • Update the form hypervisor when the template selection changes.
  • Reconcile a preselected template after asynchronous template lists finish loading.
  • Retain the existing zone hypervisor when the selected template is unavailable or has no hypervisor metadata.
  • Preserve the existing ISO, volume, and snapshot selection behavior.
  • Add focused regression coverage for KVM, XenServer, VMware, External, fallback behavior, and asynchronous preselection.

Template deployment request behavior is unchanged. The fix updates the existing form state and does not add a separate hypervisor parameter to template deployment requests.

Validation

Validated exact head 535dc17c579cbed705e7f34e06a1d343fc446641 against Apache 4.22 base 532852824a9729ff9f073e3678d9d0bd8afeb059.

  • Focused regression suite: 8 passed.
  • Sensitivity check against the unfixed base: 5 of 8 tests failed for the intended stale-hypervisor behavior.
  • Full UI unit suite: 183 passed.
  • UI lint: passed.
  • Production UI build: passed with Node 16.20.2 and npm 8.19.4, matching the repository UI workflow runtime.
  • QA-JID-974 evidence: a real ready External template was preselected and the deploy review displayed External instead of the zone value.

@Dogface2k
Dogface2k marked this pull request as draft August 6, 2026 10:21
@Dogface2k
Dogface2k marked this pull request as ready for review August 6, 2026 10:32
@Dogface2k
Dogface2k marked this pull request as draft August 6, 2026 10:43
@Dogface2k
Dogface2k force-pushed the fix/issue-13786-hypervisor-label branch 2 times, most recently from 022dbf3 to 171445b Compare August 6, 2026 11:08
@Dogface2k
Dogface2k marked this pull request as ready for review August 6, 2026 11:50
@Dogface2k
Dogface2k marked this pull request as draft August 6, 2026 12:20
@Dogface2k
Dogface2k force-pushed the fix/issue-13786-hypervisor-label branch from 4788654 to 3fefbb5 Compare August 6, 2026 22:06
@shwstppr

shwstppr commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13813 (QA-JID-973)

@Dogface2k
Dogface2k marked this pull request as ready for review August 8, 2026 14:03
@Dogface2k
Dogface2k marked this pull request as draft August 8, 2026 14:25
@Dogface2k
Dogface2k force-pushed the fix/issue-13786-hypervisor-label branch from 3fefbb5 to 535dc17 Compare August 8, 2026 15:28
@Dogface2k

Copy link
Copy Markdown
Collaborator Author

@blueorangutan ui

Please build the exact current PR head for final validation: 535dc17c579cbed705e7f34e06a1d343fc446641.

@blueorangutan

Copy link
Copy Markdown

@Dogface2k a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13813 (QA-JID-974)

@Dogface2k

Dogface2k commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator Author

Validated exact head 535dc17c579cbed705e7f34e06a1d343fc446641 on QA-JID-974.

Using a real ready External template, the deploy flow preselected QA simulator UI fixture - External hypervisor (PR 13813) and displayed its External hypervisor.

Deploy review showing the selected External template and External hypervisor

@Dogface2k
Dogface2k marked this pull request as ready for review August 8, 2026 17:37
@DaanHoogland DaanHoogland linked an issue Aug 10, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.70%. Comparing base (5328528) to head (535dc17).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #13813   +/-   ##
=========================================
  Coverage     17.69%   17.70%           
+ Complexity    15835    15831    -4     
=========================================
  Files          5925     5925           
  Lines        533539   533549   +10     
  Branches      65274    65277    +3     
=========================================
+ Hits          94427    94482   +55     
+ Misses       428435   428381   -54     
- Partials      10677    10686    +9     
Flag Coverage Δ
uitests 3.89% <ø> (+0.20%) ⬆️
unittests 18.77% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland added this to the 4.22.2 milestone Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Deploy form shows incorrect hypervisor type

5 participants