CLOUDSTACK-9792: Add upgrade path for 4.9.3.0 - #1951
Conversation
| -- Schema upgrade from 4.9.2.0 to 4.9.3.0; | ||
| --; | ||
|
|
||
| INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, hypervisor_type, hypervisor_version, max_guests_limit, max_data_volumes_limit, storage_motion_supported) values (UUID(), 'XenServer', '7.0.0', 500, 13, 1); |
There was a problem hiding this comment.
Note: On fwd merging, this can be re-executed in 4.9.2.0->4.10.0.0 upgrade path.
There was a problem hiding this comment.
@rhtyd I thought that this would be in the 4.9.2.0->4.9.3.0 path which is a subset to the 4.10.0.0 path. So in theory, it should be only executed once correct?
There was a problem hiding this comment.
@syed depends on which we release first I'd say.
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-504 |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@borisstoyanov an explicit integration test is not necessary if Travis passes, since all changes are around db upgrade/version. |
|
Just want to confirm it fresh installs and upgrades the DB to 4.9.3. will cancel the run after as I'm planning to do an upgrade scenario as well. |
|
Thanks @borisstoyanov |
|
Requesting for review - @DaanHoogland @abhinandanprateek @karuturi @koushik-das @syed |
|
I already see schema-4920to41000.sql and the corresponding cleanup file in master. So how will this fit in the overall scheme? Is there any plans for 4.9.3? |
|
@koushik-das there is plan for 4.9.3, though the db schema change to insert/update the hypervisor capability need to go into 4.10.0 either with this PR carefully fwd-merged (which I can help with) or as a separate PR targeted only for 4.10. 4.9.x should not have unnecessary db changes, therefore 4.9.2->4.9.3 is not expected of any other db changes, with this assumption and that 4.9.3 should be worked upon in next few months this would add an upgrade path from both 4.9.2/4.9.3 to 4.10.0. |
|
@rhtyd If I understand correctly if we add the DB changes in 4.9.2->4.9.3 then after forward merging, upgrade from 4.9.2->4.10.0 should not have any problems with idempotency correct? |
|
@syed yes there is no problem I see, with |
|
Thanks @rhtyd for confirming. LGTM 👍 |
|
ping @karuturi let's merge this? |
|
Ping @karuturi |
|
@rhtyd Can you merge this and also fwd-merge to master? |
|
@karuturi thanks, this will require some merge-conflicts on master. Will do it later today or tomorrow. Since it's not a blocker for 4.10 and 4.9.3 release work has not started, I'll assume this a low priority. |
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
@resmo @FabriceBrazier @karuturi I've moved from commits/changes from #2111 and eee1e1a to 4.9.3.0 upgrade path. If you're all okay with this, I can fwd-merge this as follows:
Pinging for additional review/comments - @wido @DaanHoogland @abhinandanprateek and others |
|
@blueorangutan package |
|
LGTM |
98e96bb to
eed54e0
Compare
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-737 |
- Fix now() to utc timestamp Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
@blueorangutan package |
|
I'll be testing and fwd-merging this with the approach described yesterday. /cc @karuturi |
CLOUDSTACK-9792: Add upgrade path for 4.9.3.0 This adds an upgrade path from 4.9.2.0 to 4.9.3.0, this also includes changes from PR #1928 that adds missing hypervisor capability in 4.9/4.10+. This also fixes a db-cleanup path sequence issues, with that puts 4.10 after 4.1.0, and before 4.2.0. Once validated I can help merge this on master, since this will cause merge conflicts on fwd-merging. Ping - @syed @karuturi @borisstoyanov @DaanHoogland @abhinandanprateek Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
10 participants
This adds an upgrade path from 4.9.2.0 to 4.9.3.0, this also includes changes from PR #1928 that adds missing hypervisor capability in 4.9/4.10+. This also fixes a db-cleanup path sequence issues, with that puts 4.10 after 4.1.0, and before 4.2.0.
Once validated I can help merge this on master, since this will cause merge conflicts on fwd-merging.
Ping - @syed @karuturi @borisstoyanov @DaanHoogland @abhinandanprateek