CLOUDSTACK-9929: Do not gather statistics for CDROM or FLOPPY devices - #2131
Merged
Conversation
Libvirt / Qemu (KVM) does not collect statistics about these either. On some systems it might even yield a 'internal error' from libvirt when attempting to gather block statistics from such devices. For example Ubuntu 16.04 (Xenial) has a issue with this. Skip them when looping through all devices. Signed-off-by: Wido den Hollander <wido@widodh.nl>
Contributor
|
Thanks for the fix @wido |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-754 |
Contributor
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1139)
|
borisstoyanov
approved these changes
Jun 2, 2017
borisstoyanov
left a comment
borisstoyanov
left a comment
Contributor
There was a problem hiding this comment.
Tests and code LGTM
Contributor
|
Thanks @wido, tested it LGTM |
Contributor
Author
|
@rhtyd: Can you merge it into 4.9 and forward into master? |
Member
|
LGTM, merging now. |
yadvr
approved these changes
Jul 14, 2017
Contributor
Author
|
This PR was merged into 4.9 but wasn't merged forward into 4.10 it seems. We need to fix that. |
Member
|
@wido checked, this was forward merged on master. The changes are on both 4.10 and master. |
hkwi
added a commit
to hkwi/libvirt_exporter
that referenced
this pull request
May 2, 2018
We get "internal error: cannot find statistics for device ..." error for CDROM or Floppy. This is same with apache/cloudstack#2131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libvirt / Qemu (KVM) does not collect statistics about these either.
On some systems it might even yield a 'internal error' from libvirt
when attempting to gather block statistics from such devices.
For example Ubuntu 16.04 (Xenial) has a issue with this.
Skip them when looping through all devices.
Signed-off-by: Wido den Hollander wido@widodh.nl