CLOUDSTACK-10042: Properly show ICMP SecGroup Rules - #2233
Merged
Conversation
A simple if-statement would fail if either the type or code were 0 as that if-statement failed them. By checking if they are defined and casting them to a String afterwards this makes the if-statement properly resolve and show the rule as it should. Signed-off-by: Wido den Hollander <wido@widodh.nl>
Member
|
@borisstoyanov can you help validate this, thanks. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Contributor
Author
|
Thanks @rhtyd ! A screenshot to show it works for me :)
|
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-941 |
yadvr
reviewed
Aug 9, 2017
yadvr
left a comment
yadvr
left a comment
Member
There was a problem hiding this comment.
LGTM, did not check the UI myself though.
Member
|
Checked manually, LGTM. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple if-statement would fail if either the type or code were 0
as that if-statement failed them.
By checking if they are defined and casting them to a String afterwards
this makes the if-statement properly resolve and show the rule as it should.
Signed-off-by: Wido den Hollander wido@widodh.nl