Skip to content

CLOUDSTACK-10340: Add setter to hypervisorType in VMInstanceVO - #2504

Merged
yadvr merged 1 commit into
apache:4.11from
shapeblue:setter-vminstancevo
Mar 23, 2018
Merged

CLOUDSTACK-10340: Add setter to hypervisorType in VMInstanceVO#2504
yadvr merged 1 commit into
apache:4.11from
shapeblue:setter-vminstancevo

Conversation

@yadvr

@yadvr yadvr commented Mar 22, 2018

Copy link
Copy Markdown
Member

Description

This adds a missing setter to set hypervisorType in VMInstanceVO. The consumer is a 3rd party network plugin that may require the method for integration.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All new and existing tests passed.

@blueorangutan package

This adds a missing setter to set hypervisorType in VMInstanceVO.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.11.1.0 milestone Mar 22, 2018
@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1805

@yadvr

yadvr commented Mar 22, 2018

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@ustcweizhou

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@nitin-maharana

Copy link
Copy Markdown
Contributor

LGTM

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2399)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37455 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2504-t2399-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_extract_template Failure 128.29 test_templates.py
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
test_06_download_detached_volume Failure 137.64 test_volumes.py
test_04_rvpc_network_garbage_collector_nics Failure 509.98 test_vpc_redundant.py

@yadvr

yadvr commented Mar 23, 2018

Copy link
Copy Markdown
Member Author

Thanks all, merging this based on code reviews and test results (the failures were not caused by this PR, but were intermitted/env caused).

@yadvr
yadvr merged commit 2a06869 into apache:4.11 Mar 23, 2018
@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

asfgit pushed a commit that referenced this pull request Mar 23, 2018
CLOUDSTACK-10341: VR minor fixes to systemvmtemplate (#2468)
CLOUDSTACK-10340: Add setter to hypervisorType in VMInstanceVO (#2504)

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants