Skip to content

CLOUDSTACK-10227: Fix mkdir path for centos rpms - #2513

Merged
yadvr merged 1 commit into
apache:4.11from
shapeblue:rpm-usrbin-fix
Mar 27, 2018
Merged

CLOUDSTACK-10227: Fix mkdir path for centos rpms#2513
yadvr merged 1 commit into
apache:4.11from
shapeblue:rpm-usrbin-fix

Conversation

@yadvr

@yadvr yadvr commented Mar 27, 2018

Copy link
Copy Markdown
Member

Description

This fixes the mkdir path /usr/bin for el6/7 rpms.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All new and existing tests passed.

@blueorangutan package

This fixes the mkdir path `/usr/bin` for el6/7 rpms.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.11.1.0 milestone Mar 27, 2018
@yadvr yadvr self-assigned this Mar 27, 2018
@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@wido wido left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! LGTM

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1838

@yadvr
yadvr changed the base branch from master to 4.11 March 27, 2018 12:36
@yadvr

yadvr commented Mar 27, 2018

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1840

@resmo resmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice any issues while installing... but
LGTM

@rafaelweingartner

Copy link
Copy Markdown
Member

As @resmo said, I also did not notice any problem while using the packaging scripts.

This is the issue reported in the security list, right @rhtyd ?

@yadvr

yadvr commented Mar 27, 2018

Copy link
Copy Markdown
Member Author

Yes @rafaelweingartner. @resmo you're right, I think none of us have never faced any problems due to this issue.

@yadvr

yadvr commented Mar 27, 2018

Copy link
Copy Markdown
Member Author

Since this is a packaging only fix, merging based on a successful packaging build and 2+ lgtms.

@yadvr
yadvr merged commit 48e6989 into apache:4.11 Mar 27, 2018
@yadvr yadvr changed the title packaging: Fix mkdir path for centos rpms CLOUDSTACK-10227: Fix mkdir path for centos rpms Mar 27, 2018
asfgit pushed a commit that referenced this pull request Mar 27, 2018
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants