Skip to content

CLOUDSTACK-10376: UI: Create VPC Offering does not show ConfigDrive a… - #2622

Merged
yadvr merged 1 commit into
apache:4.11from
nuagenetworks:bugfix/CLOUDSTACK-10376
May 4, 2018
Merged

CLOUDSTACK-10376: UI: Create VPC Offering does not show ConfigDrive a…#2622
yadvr merged 1 commit into
apache:4.11from
nuagenetworks:bugfix/CLOUDSTACK-10376

Conversation

@fmaximus

@fmaximus fmaximus commented May 3, 2018

Copy link
Copy Markdown
Contributor

Description

Added ConfigDrive as UserData provider in dropdown of Create VPC Offering

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

Updated UI

How Has This Been Tested?

Manually.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@fmaximus fmaximus added this to the 4.11.1.0 milestone May 3, 2018

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a solid peace of code ;)

@yadvr
yadvr merged commit 10a10f6 into apache:4.11 May 4, 2018
@yadvr

yadvr commented May 4, 2018

Copy link
Copy Markdown
Member

This is purely UI code, merged this based on code reviews and travis already passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants