correct permissions in spec file and fix class path specified variable by svenvogel · Pull Request #3030 · apache/cloudstack

svenvogel · 2018-11-14T23:36:14Z

Description

There are only two small, small, small really small fixes.

Install CentOS 7 e.g. Build 1804 and Java build 1.8.0_181

if you inspect systemd in debug mode you will see some errors
1.

permission of the cloudstack-managment.service are not corretly set
2.

invalid classpath specified. it seems the string which is used will be divided... we now we use ${..} like the lines above ... 😕

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

We tested it on our test environment! We create own build with our test pipeline.

CentOS 7 Build 1804, Cloudstack 4.11, Java Build 1.8.0_181, systemd Build 219-57.el7_5.3

yadvr · 2018-11-15T04:08:26Z

LGTM, @svenvogel if possible could you rebase and edit the branch to 4.11. It will be useful to get this for 4.11 as well. Also, do you think we should also fix for el6/centos6 spec?
Thanks.

yadvr · 2018-11-15T04:09:22Z

Nevermind my comment for centos6, it does not have systemd so I guess does not apply.

svenvogel · 2018-11-15T09:13:07Z

@rhtyd changed! :)

yadvr · 2018-11-15T09:17:02Z

Can you rebase against 4.11 as well, I see several extra commits @svenvogel

yadvr · 2018-11-16T11:25:09Z

@svenvogel please rebase against 4.11, or if it's difficult you can try this:

note down the shas of the two commits
git checkout your-branch
git reset --hard origin/4.11
git cherry-pick
git cherry-pick
git push <remote|origin> your-branch -fv (and then edit the PR branch to 4.11!)

svenvogel · 2018-11-17T15:25:29Z

Hi @rhtyd i tried my best to get it working... cool step by step guide... is it now okay?

DaanHoogland · 2018-11-19T08:47:46Z

+<<<<<<< HEAD
 ExecStart=/usr/bin/jsvc -home "${JAVA_HOME}" -user "${CLOUDSTACK_USER}" -cp "${JARS}:${CLASSPATH}" -errfile ${LOGDIR}/${NAME}.err -cwd ${LOGDIR} -pidfile "${CLOUDSTACK_PID}" ${JAVA_OPTS} "${BOOTSTRAP_CLASS}"
 ExecStop=/usr/bin/jsvc -cp "$JARS:$CLASSPATH" -pidfile "$CLOUDSTACK_PID" -stop "$BOOTSTRAP_CLASS"
+=======


this is a git artifact, @svenvogel . It should not show here, so something went wrong :(

@DaanHoogland can you check again ;)

looks good now.

DaanHoogland · 2018-11-19T12:42:50Z

@rhtyd not sure if we need full testing but I'll package to get at least that part covered.
@blueorangutan package

blueorangutan · 2018-11-19T12:43:49Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-11-19T13:17:40Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2447

DaanHoogland · 2018-11-19T14:59:07Z

better not sorry
@blueorangutan test

blueorangutan · 2018-11-19T14:59:49Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

svenvogel · 2018-11-19T15:34:17Z

@DaanHoogland ca we merge it? what do you think?

DaanHoogland · 2018-11-20T07:46:54Z

@blueorangutan test

blueorangutan · 2018-11-20T07:47:53Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2018-11-20T08:42:00Z

@blueorangutan test

svenvogel · 2018-11-23T20:05:04Z

@rhtyd can you test again?

yadvr · 2018-11-24T01:40:35Z

@blueorangutan package

blueorangutan · 2018-11-24T01:41:09Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-11-24T02:07:23Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2455

yadvr · 2018-11-24T02:09:34Z

@blueorangutan test

blueorangutan · 2018-11-24T02:10:10Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

svenvogel · 2018-11-27T00:27:29Z

@rhtyd looks good? can we merge it?

yadvr · 2018-11-27T06:02:11Z

@blueorangutan test

blueorangutan · 2018-11-27T06:02:24Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov

With the last failure management failed to start @rhtyd @svenvogel, don't know if it's related to these changes

yadvr · 2018-11-27T15:13:52Z

A bug in trillian was fixed. Let's retry.
@blueorangutan test

blueorangutan · 2018-11-27T15:14:26Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

svenvogel · 2018-11-29T19:18:39Z

@rhtyd @DaanHoogland is it ready?

yadvr · 2018-11-29T21:26:06Z

Looks like some errors in pkging or env deployment
@blueorangutan package

blueorangutan · 2018-11-29T21:26:36Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-11-29T21:41:50Z

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2473

yadvr · 2018-11-29T21:43:59Z

@blueorangutan test

blueorangutan · 2018-11-29T21:44:36Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2018-11-30T12:49:41Z

@svenvogel the mgmt server failed to start due to the JAVA_DEBUG option. I tried to define an empty variable in /etc/default/cloudstack-management but it still failed to run. On removing it, it worked. Was it intended to add such a variable? Please fix accordingly, I've removed it to make tests work.
@blueorangutan package

blueorangutan · 2018-11-30T12:50:40Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-11-30T13:09:21Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2474

yadvr · 2018-11-30T13:58:44Z

@blueorangutan test

blueorangutan · 2018-11-30T13:59:42Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-11-30T20:05:34Z

Trillian test result (tid-3239)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 20395 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3030-t3239-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 66 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	1.36	test_host_maintenance.py
test_hostha_kvm_host_degraded	`Error`	7.85	test_hostha_kvm.py

svenvogel · 2018-11-30T23:14:54Z

Thanks @rhtyd you are right. That was a artifact from my testing.

borisstoyanov

LGTM

yadvr approved these changes Nov 15, 2018

View reviewed changes

DaanHoogland approved these changes Nov 15, 2018

View reviewed changes

svenvogel changed the base branch from master to 4.11 November 15, 2018 09:11

yadvr changed the base branch from 4.11 to master November 16, 2018 11:23

svenvogel changed the base branch from master to 4.11 November 16, 2018 14:52

svenvogel changed the base branch from 4.11 to master November 16, 2018 14:53

svenvogel changed the base branch from master to 4.11 November 16, 2018 14:53

svenvogel changed the base branch from 4.11 to master November 16, 2018 14:53

svenvogel force-pushed the improve-spec-file branch from d3ec7a7 to c053281 Compare November 17, 2018 15:23

svenvogel changed the base branch from master to 4.11 November 17, 2018 15:24

DaanHoogland reviewed Nov 19, 2018

View reviewed changes

Sven Vogel added 3 commits November 19, 2018 11:35

change cloudstack-management.service to the correct permissions

ed3757d

remove artifacts

f5f11b9

add quotes

5d7fc2b

svenvogel force-pushed the improve-spec-file branch from c053281 to 5d7fc2b Compare November 19, 2018 10:43

borisstoyanov reviewed Nov 27, 2018

View reviewed changes

yadvr added 2 commits November 30, 2018 18:13

Update cloudstack-management.service

a14b3d4

Update cloudstack-management.service

ad80704

yadvr added this to the 4.11.3.0 milestone Nov 30, 2018

yadvr merged commit 1709792 into apache:4.11 Nov 30, 2018

borisstoyanov reviewed Dec 5, 2018

View reviewed changes

Uh oh!

Conversation

svenvogel commented Nov 14, 2018

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

yadvr commented Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yadvr commented Nov 15, 2018

Uh oh!

svenvogel commented Nov 15, 2018

Uh oh!

yadvr commented Nov 15, 2018

Uh oh!

yadvr commented Nov 16, 2018

Uh oh!

svenvogel commented Nov 17, 2018

Uh oh!

DaanHoogland Nov 19, 2018

Choose a reason for hiding this comment

Uh oh!

svenvogel Nov 19, 2018

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Nov 19, 2018

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Nov 19, 2018

Uh oh!

blueorangutan commented Nov 19, 2018

Uh oh!

blueorangutan commented Nov 19, 2018

Uh oh!

DaanHoogland commented Nov 19, 2018

Uh oh!

blueorangutan commented Nov 19, 2018

Uh oh!

svenvogel commented Nov 19, 2018

Uh oh!

DaanHoogland commented Nov 20, 2018

Uh oh!

blueorangutan commented Nov 20, 2018

Uh oh!

DaanHoogland commented Nov 20, 2018

Uh oh!

svenvogel commented Nov 23, 2018

Uh oh!

yadvr commented Nov 24, 2018

Uh oh!

blueorangutan commented Nov 24, 2018

Uh oh!

blueorangutan commented Nov 24, 2018

Uh oh!

yadvr commented Nov 24, 2018

Uh oh!

blueorangutan commented Nov 24, 2018

Uh oh!

svenvogel commented Nov 27, 2018

Uh oh!

yadvr commented Nov 27, 2018

Uh oh!

blueorangutan commented Nov 27, 2018

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Nov 27, 2018

Uh oh!

blueorangutan commented Nov 27, 2018

Uh oh!

svenvogel commented Nov 29, 2018

Uh oh!

yadvr commented Nov 29, 2018

Uh oh!

blueorangutan commented Nov 29, 2018

Uh oh!

blueorangutan commented Nov 29, 2018

yadvr commented Nov 15, 2018 •

edited

Loading