Skip to content

ssvm: apply MTU value on storage/management nic if available - #3370

Merged
yadvr merged 1 commit into
apache:4.11from
shapeblue:mtu-ssvm-fix
Jun 4, 2019
Merged

ssvm: apply MTU value on storage/management nic if available#3370
yadvr merged 1 commit into
apache:4.11from
shapeblue:mtu-ssvm-fix

Conversation

@yadvr

@yadvr yadvr commented Jun 3, 2019

Copy link
Copy Markdown
Member

If mtu= value is defined in the parameters received by the SSVM agent
per the secstorage.vm.mtu.size setting, it applies the MTU setting on
eth1 which is the storage/management nic.

Fixes #3369

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

If mtu= value is defined in the parameters received by the SSVM agent
per the secstorage.vm.mtu.size setting, it applies the MTU setting on
eth1 which is the storage/management nic.

Fixes apache#3369

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
yadvr requested review from PaulAngus and borisstoyanov June 3, 2019 12:24
@yadvr yadvr added this to the 4.11.3.0 milestone Jun 3, 2019
@yadvr

yadvr commented Jun 3, 2019

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2830

@yadvr

yadvr commented Jun 3, 2019

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3638)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26813 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3370-t3638-kvm-centos7.zip
Smoke tests completed. 68 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on code

@anuragaw anuragaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(based on code and test results)

@yadvr
yadvr merged commit 42501ce into apache:4.11 Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants