Reject missing main header in ArjArchiveInputStream.readMainHeader - #793
Merged
Merged
Conversation
readHeader returns null for the zero-length basic header that marks the end of an arj archive. readLocalFileHeader already tests for it, but readMainHeader passed it straight to ByteArrayInputStream, so an archive starting with the terminator threw NullPointerException instead of ArchiveException.
garydgregory
added a commit
that referenced
this pull request
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readHeader returns null when the basic header size field is zero, which is the arj end-of-archive marker, and readLocalFileHeader tests for that before using the result. readMainHeader does not, so an archive whose first header is the terminator reaches new ByteArrayInputStream(null) and throws NullPointerException out of a constructor that declares IOException; it escapes ArchiveStreamFactory the same way, since matches only needs the two signature bytes for the format to be detected. the whole input is 60 ea 00 00. throwing ArchiveException there matches the rest of readHeader's malformed-header handling, and the self-extracting path already rejects those bytes that way through findMainHeader, so only the streaming path changes. readHeader has two callers and this was the one missing the check.
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.