Extract surrogate fixup from StrBuilder.reverse() to reduce structural depth - #1764
Closed
cripto-bot wants to merge 1 commit into
Closed
Extract surrogate fixup from StrBuilder.reverse() to reduce structural depth#1764cripto-bot wants to merge 1 commit into
cripto-bot wants to merge 1 commit into
Conversation
…rogatePairs() Reduces structural depth from 6 to 5. Extracts surrogate pair restoration to a separate, testable method. No behavioral change — all existing behavior preserved. Flagged by GraphLang structural analysis (depth exceeded limit of 6).
cripto-bot
force-pushed
the
graphlang-reverse-fix
branch
from
July 31, 2026 15:07
8e23041 to
1168e56
Compare
Member
|
@cripto-bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the surrogate pair restoration logic from
StrBuilder.reverse()into a dedicatedrestoreSurrogatePairs()method.Motivation
The surrogate fixup loop was nested inside the main reversal method, increasing structural depth. Extracting it:
Change
private void restoreSurrogatePairs(char[], int)reverse()when surrogates are detectedTesting
All existing
StrBuilderTesttests should pass. The change is purely structural — same operations in same order.