build: remove redundant license download step to speed up distribution building - #19853
Open
FrankChen021 wants to merge 1 commit into
Open
build: remove redundant license download step to speed up distribution building#19853FrankChen021 wants to merge 1 commit into
FrankChen021 wants to merge 1 commit into
Conversation
FrankChen021
marked this pull request as ready for review
August 2, 2026 08:15
Contributor
There was a problem hiding this comment.
Pull request overview
This PR speeds up distribution builds by removing the legacy license-maven-plugin execution that attempted to download dependency license texts during the dist profile build, while keeping Druid’s existing licenses.yaml-based license/notice generation workflow intact.
Changes:
- Removed the
org.codehaus.mojo:license-maven-plugindownload-licensesexecution from thedistprofile in the distribution module POM. - Left the existing
apache-releaseprofile’s curated license report/check scripts and distribution assembly behavior unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FrankChen021
commented
Aug 2, 2026
FrankChen021
left a comment
Member
Author
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, build lifecycle, and integration risks; no issues found.
Reviewed 1 of 1 changed files.
This is an automated review by Codex GPT-5.6-Sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
license-maven-pluginfrom thedistprofile.licenses.yaml-based license and notice generation unchanged.Motivation
The distribution build currently invokes the plugin's
download-licensesgoal:This goal reads license URLs from dependency POMs and attempts to download them. During distribution builds, it produces numerous warnings for missing or unreachable URLs, including:
The generated files under
target/generated-resourcesare not consumed by the distribution assembly. The download phase takes approximately one minute and delays the build while waiting for network timeouts.In the reported build, removing the plugin reduced the distribution module time by approximately 1 minute and 10 seconds:
download-licenses02:11download-licenses01:01This change therefore eliminates the warnings and significantly reduces distribution build time.
Why this is safe
The legacy
license-maven-pluginwas introduced in the original distribution packaging in 2015, before PR numbers were consistently recorded in the repository.licenses.yamlregistry and license-generation workflow.generate-binary-license.pyandcheck-licenses.pyscripts.The distribution assembly packages
LICENSE.BINARYasLICENSE,NOTICE.BINARYasNOTICE, and the curatedlicenses/**files. It does not package the plugin'starget/generated-resourcesoutput.Therefore, this change removes only an obsolete network-download step. The shipped license files and Apache release license validation remain unchanged.
Verification
mvn -o -pl distribution -Pdist validate -DskipTests -Dweb.console.skip=true -Pskip-static-checkssuccessfully.distPOM.license-maven-pluginanddownload-licensesare no longer present.git diff --check.