fix(roam): respect globalPan mutex in mouseup/mousedown to keep zoom cursor - #21724
Open
waterWang wants to merge 1 commit into
Open
fix(roam): respect globalPan mutex in mouseup/mousedown to keep zoom cursor#21724waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…cursor When the toolbox dataZoom is active, the BrushController takes the 'globalPan' interaction mutex and the RoamController's mousemove handler already defers to it. However the mousedown/mouseup handlers were not checking the mutex, so releasing the mouse after a zoom drag reset the cursor back to 'default' (via _decideCursorStyle) instead of keeping the zoom crosshair cursor. Add the same interactionMutex.isTaken(zr, 'globalPan') guard to _mousedownHandler and _mouseupHandler so the RoamController never overrides the cursor while the dataZoom brush is active. close apache#21723
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
waterWang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the toolbox dataZoom button is active and the user clicks on the chart to zoom, the cursor changes to a default/gesture state after releasing the mouse. The expected behavior is that the cursor should remain as the zoom crosshair cursor while the dataZoom tool is active.
Root Cause
The
RoamController._mousemoveHandlerproperly checksinteractionMutex.isTaken(zr, 'globalPan')and defers to the BrushController when the dataZoom brush is active. However,_mousedownHandlerand_mouseupHandlerwere not checking this mutex:_mousedownHandlerwould setthis._dragging = trueeven when the dataZoom brush owns the interaction_mouseupHandlerwould reset the cursor to'default'(via_decideCursorStyle) on mouse release, overriding the zoom crosshair cursorFix
Add the same
interactionMutex.isTaken(zr, 'globalPan')guard to_mousedownHandlerand_mouseupHandler, consistent with the existing check in_mousemoveHandler. This prevents the RoamController from interfering with the cursor when the BrushController (dataZoom) holds the globalPan mutex.How to Reproduce
Closes #21723