fix(legend): use bottom:0 default so legend no longer overlaps axis labels - #21726
Open
waterWang wants to merge 1 commit into
Open
fix(legend): use bottom:0 default so legend no longer overlaps axis labels#21726waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…abels The default legend position used bottom: tokens.size.m (15px) from the container bottom. When the grid has its own bottom offset or containLabel is configured, the x-axis labels extend below the grid and can overlap with the legend sitting 15px up. Setting the default bottom to 0 pushes the legend down to the container's bottom edge, leaving the space between grid and legend to the axis labels, which matches how the layout reference is consumed. Users can still override with an explicit 'bottom'. Closes apache#21662.
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the chart has a grid with a
bottomoffset (orcontainLabel: true), the legend overlaps with the x-axis labels. This is because the default legend position isbottom: tokens.size.m(15px from the container bottom), which places the legend too close to the grid's bottom edge where axis labels are rendered.Steps to Reproduce
grid: { bottom: 80 }(or any explicit bottom value)Current Behavior
Legend overlaps axis labels when the grid has a bottom offset.
Workaround
Fix
Changed the default
bottomfromtokens.size.m(15px) to0. This pushes the legend to the container's bottom edge, leaving the space between the grid and the legend to the axis labels. Users can still override with an explicitbottomvalue.Related
Closes #21662