feat(java): remove sun.misc.Unsafe for jdk25#3702
Merged
Merged
Conversation
pandalee99
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
JDK25+ removes the remaining viable
sun.misc.Unsafepaths Fory used for Java object creation, field access, string internals, and memory operations. This PR makes the Java runtime continue to support modern JDKs while preserving the existing JDK8-24, Android, GraalVM, native-mode, and xlang behavior where applicable.What does this PR do?
fory-coreas a multi-release jar with JDK25-specific classes and module metadata, while keeping the root implementation for JDK8-24.java.base/java.lang.invokeopen for classpath and module-path users.Related issues
Closes #3729
Closes #2090
Closes #2606
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Yes. Java users on JDK25+ must open
java.base/java.lang.invoketo Fory:--add-opens=java.base/java.lang.invoke=ALL-UNNAMED--add-opens=java.base/java.lang.invoke=org.apache.fory.coreNo binary protocol compatibility change is intended.
Benchmark
This PR adds Java25 benchmark coverage under
benchmarks/java25and a benchmark MR-JAR check. No benchmark result table is included here.