GUACAMOLE-2273: Implement FreeRDP AuthenticateEx callback and handle deprecation of Authenticate callback.#670
Open
necouchman wants to merge 3 commits into
Open
GUACAMOLE-2273: Implement FreeRDP AuthenticateEx callback and handle deprecation of Authenticate callback.#670necouchman wants to merge 3 commits into
necouchman wants to merge 3 commits into
Conversation
necouchman
marked this pull request as draft
May 4, 2026 01:44
necouchman
force-pushed
the
jira/2273
branch
2 times, most recently
from
May 4, 2026 15:44
7696572 to
58d152a
Compare
necouchman
marked this pull request as ready for review
May 4, 2026 15:47
Contributor
Author
|
@mike-jumper @corentin-soriano @sschiffli Anyone do a quick review of this? |
necouchman
force-pushed
the
jira/2273
branch
4 times, most recently
from
July 15, 2026 17:37
675b8c4 to
cf038c1
Compare
mike-jumper
reviewed
Jul 15, 2026
…deprecation of Authenticate callback.
mike-jumper
requested changes
Jul 19, 2026
| provided with the connection. | ||
| ----------------------------------------------------])], | ||
| [[#include <freerdp/freerdp.h>]])], | ||
| [[#include <freerdp/freerdp.h>]]) |
Contributor
There was a problem hiding this comment.
With -Werror, this check will fail upon merely including freerdp/freerdp.h for recent FreeRDP 3.x, so this may erroneously report "no".
Contributor
Author
There was a problem hiding this comment.
Hmm...I tested up to 3.30.0, the latest tag in the FreeRDP code, and it seems to work properly?
...
checking for rdpSettings.AllowUnanouncedOrdersFromServer... yes
checking for freerdp.VerifyCertificateEx... yes
checking for freerdp.AuthenticateEx... yes
...
…sons; support requesting gateway authentication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the
AuthenticateExcallback for FreeRDP, and handles versions of FreeRDP where theAuthenticatecallback has been deprecated and compiled out.