Skip to content

GUACAMOLE-2294: Address multiple minor resource leaks.#685

Merged
mike-jumper merged 3 commits into
apache:staging/1.6.1from
necouchman:working/fix-resource-leaks
Jul 16, 2026
Merged

GUACAMOLE-2294: Address multiple minor resource leaks.#685
mike-jumper merged 3 commits into
apache:staging/1.6.1from
necouchman:working/fix-resource-leaks

Conversation

@necouchman

Copy link
Copy Markdown
Contributor

This addresses a few minor resource leaks identified by Coverity/Blackduck. Nothing major, just some cleanup.

It's worth noting that our macro for freeing memory, PRIV_guac_mem_free, doesn't seem to handle freeing const * members/pointers.

@necouchman
necouchman changed the base branch from main to staging/1.6.1 July 5, 2026 18:49
Comment thread src/terminal/terminal.c Outdated
Comment thread src/terminal/display.c Outdated
@necouchman
necouchman force-pushed the working/fix-resource-leaks branch from c3180e3 to 5ca9f80 Compare July 13, 2026 18:31
@mike-jumper

Copy link
Copy Markdown
Contributor

It's worth noting that our macro for freeing memory, PRIV_guac_mem_free, doesn't seem to handle freeing const * members/pointers.

We provide guac_mem_free_const() as a convenience for this, but yeah - the automatic NULL assignment of guac_mem_free() just can't (or shouldn't) be done in the const case.

@mike-jumper
mike-jumper merged commit c942b8b into apache:staging/1.6.1 Jul 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants