Skip to content

HBASE-30138 Upgrade hbase-server to use junit5 Part16#8288

Open
liuxiaocs7 wants to merge 3 commits into
branch-2.5from
HBASE-30138-branch-2.5
Open

HBASE-30138 Upgrade hbase-server to use junit5 Part16#8288
liuxiaocs7 wants to merge 3 commits into
branch-2.5from
HBASE-30138-branch-2.5

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 added the backport This PR is a back port of some issue or issues already committed to master label May 30, 2026
@liuxiaocs7 liuxiaocs7 requested a review from Copilot May 30, 2026 15:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates a batch of hbase-server (and one hbase-endpoint) tests from JUnit4 to JUnit5 as part of HBASE-30138 (Part 16), aligning test annotations, assertions, and parameterization with the ongoing JUnit5 upgrade effort.

Changes:

  • Replaced JUnit4 lifecycle/Category/Rule usage with JUnit5 equivalents (@BeforeAll/@BeforeEach, @Tag, TestInfo, @RegisterExtension).
  • Converted JUnit4 parameterized tests to JUnit5 @TestTemplate using @HBaseParameterizedTestTemplate and Stream<Arguments> parameters().
  • Updated assertion APIs to org.junit.jupiter.api.Assertions and modernized a few test names/exception assertions.

Reviewed changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestNotCleanupCompactedFileWhenRegionWarmup.java JUnit5 migration (lifecycle + assertions + tags).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestNewVersionBehaviorFromClientSide.java JUnit5 migration; replace TestName with TestInfo; minor test method rename.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMutateRowsRecovery.java JUnit5 migration (lifecycle + tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiVersionConcurrencyControlBasic.java JUnit5 migration (tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiVersionConcurrencyControl.java JUnit5 migration (tags + Assertions static imports).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiLogThreshold.java Convert JUnit4 parameterized test to @HBaseParameterizedTestTemplate + @TestTemplate.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScannerWithNoneAndUseDataEncoding.java Convert to @HBaseParameterizedTestTemplate + constructor-based params.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScannerWithNoneAndNoDataEncoding.java Convert to @HBaseParameterizedTestTemplate + constructor-based params.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScannerWithAlgoGZAndUseDataEncoding.java Convert to @HBaseParameterizedTestTemplate + constructor-based params.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScannerWithAlgoGZAndNoDataEncoding.java Convert to @HBaseParameterizedTestTemplate + constructor-based params.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java Refactor base test to constructor-based parameters + @TestTemplate; update params generator to Stream<Arguments>.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinVersions.java JUnit5 migration; replace TestName with TestInfo; assertion updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinorCompaction.java JUnit5 migration; replace TestName with TestInfo; assertion message ordering updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMiniBatchOperationInProgress.java JUnit5 migration (tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsUserAggregate.java JUnit5 migration (lifecycle + tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableMetricsMap.java JUnit5 migration (lifecycle + tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableAggregate.java JUnit5 migration (lifecycle + tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServerAggregate.java JUnit5 migration (tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java JUnit5 migration (lifecycle + tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegion.java JUnit5 migration (tags).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsJvm.java JUnit5 migration; update lifecycle and assertion ordering.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsHeapMemoryManager.java JUnit5 migration (lifecycle + tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMergesSplitsAddToTracker.java JUnit5 migration; replace TableNameTestRule with TableNameTestExtension.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreSegmentsIterator.java JUnit5 migration (lifecycle + tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemstoreLABWithoutPool.java JUnit5 migration; replace @Ignore with @Disabled; assertion updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreLAB.java JUnit5 migration (lifecycle + tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreFlusher.java JUnit5 migration; replace TestName with TestInfo; assertion updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreChunkPool.java JUnit5 migration (lifecycle + tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java JUnit5 migration; replace TestName with TestInfo.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMajorCompaction.java Convert parameterized runner to @HBaseParameterizedTestTemplate + @TestTemplate; use TestInfo naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestLogRoller.java JUnit5 migration (lifecycle + tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueScanFixture.java JUnit5 migration (tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueHeap.java JUnit5 migration (tags + assertions + assertThrows).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java JUnit5 migration; replace TestName with TestInfo; assertion message ordering updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestJoinedScanners.java JUnit5 migration; replace expected= with assertThrows; replace TestName with TestInfo.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestIsDeleteFailure.java JUnit5 migration; replace TestName with TestInfo; tag conversion.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestInputStreamBlockDistribution.java JUnit5 migration (lifecycle + tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java JUnit5 migration; replace TestName with TestInfo; assertion updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java JUnit5 migration; replace TestName with TestInfo; convert timeout to @Timeout.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionWithInMemoryFlush.java JUnit5 migration (tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionTracing.java JUnit5 migration; replace OTel JUnit4 rule with JUnit5 extension; use TableNameTestExtension.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldClient.java Convert to @HBaseParameterizedTestTemplate-based parameterization (inherits params from base).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java Convert parameterized runner to @HBaseParameterizedTestTemplate + @TestTemplate.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java JUnit5 migration; replace TestName with TestInfo; assertion updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionOnCluster.java JUnit5 migration; replace TestName with TestInfo; tag conversion.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionFileSystem.java JUnit5 migration; replace TestName with TestInfo; assertion message ordering updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java JUnit5 migration; replace ExpectedException usage with assertThrows; assertion updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHMobStore.java JUnit5 migration; replace TestName with TestInfo; assertion updates.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHeapMemoryManager.java JUnit5 migration (tags + assertions).
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHdfsSnapshotHRegion.java JUnit5 migration (lifecycle + tags + assertions).
hbase-endpoint/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldSecureEndpoint.java JUnit5 migration + @HBaseParameterizedTestTemplate; replace @Ignore with @Disabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

liuxiaocs7 and others added 2 commits May 31, 2026 01:25
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants