HBASE-29974: Persist filter hints across scan circuit breaks#8464
Open
shubham-roy wants to merge 1 commit into
Open
HBASE-29974: Persist filter hints across scan circuit breaks#8464shubham-roy wants to merge 1 commit into
shubham-roy wants to merge 1 commit into
Conversation
| * as logically stateless. Only filters whose hint computation is based solely on immutable | ||
| * configuration (e.g. a fixed column range or a fuzzy-row pattern) should override this.</li> | ||
| * <li>The returned {@link Cell}, if non-null, must be an | ||
| * {@link org.apache.hadoop.hbase.ExtendedCell} because filters are evaluated on the server |
Contributor
There was a problem hiding this comment.
does this comment related to ExtendedCell still apply ?
Contributor
There was a problem hiding this comment.
I think it's fine to keep for backport PR if master and branch-2 already has this comment. We can update them all later as addendum PR if needed.
virajjasani
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of HBASE-29974 to branch-2.5 (cherry-picked from master 21d3fdf, PR #7882). Adapted for branch-2.5: ExtendedCell → Cell (branch-2.5 predates the ExtendedCell migration), and the nextRowViaHint fast path drops the ScannerContext.setSkippingRow calls (that API — HBASE-27558 — is not on branch-2.5). Tests unchanged (JUnit 5, delete-marker tests retained since HBASE-29039 is present); HBaseTestingUtil → HBaseTestingUtility for the pre-rename branch. No-op by default.
Generated-by: Claude Opus 4.6 (1M context) noreply@anthropic.com
(cherry picked from commit 21d3fdf)