HBASE-30099 Avoid NPE when GetBootstrapNodes RPC arrives during startup#8483
Open
Sigma-Ma wants to merge 1 commit into
Open
HBASE-30099 Avoid NPE when GetBootstrapNodes RPC arrives during startup#8483Sigma-Ma wants to merge 1 commit into
Sigma-Ma wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi maintainers, the three GitHub Actions workflows for this fork PR are awaiting approval. This PR does not modify any workflow files. Could someone with write access approve them when convenient? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
HRegionServer#getBootstrapNodesreturn an empty iterator whenbootstrapNodeManagerhas not been initialized yet.Declare
bootstrapNodeManageras volatile to ensure safe publication between the RegionServer startup thread and RPC handler threads.Add a regression test covering calls to
getBootstrapNodesbeforebootstrapNodeManagerinitialization.Why are the changes needed?
The RPC server can start accepting connections before
preRegistrationInitialization()assignsbootstrapNodeManager.If a
GetBootstrapNodesRPC arrives during this startup window,HRegionServer#getBootstrapNodesdereferences a nullbootstrapNodeManagerand throws aNullPointerException.Returning an empty iterator during this window avoids the startup race and allows callers to continue bootstrap-node discovery normally.
How was this patch tested?
mvn -pl hbase-server -am \ -Dtest=TestBootstrapNodeManager \ -Dsurefire.failIfNoSpecifiedTests=false \ -DskipITs \ test