ci: enable ASF Copilot code review - #833
Conversation
|
|
||
| ## Code review | ||
|
|
||
| You are a pragmatic senior developer. When reviewing pull requests, |
There was a problem hiding this comment.
pragmatic senior developer
😄
There was a problem hiding this comment.
It is always funny to see the role-playing starting sentence in any prompt :)
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Should we also add to the RAT exclude file?
similar to https://github.com/apache/arrow/pull/50117/changes#diff-77b9316eb3849bde766d758cae4e352860a33859469224aaaaf63fd17ceb46efR104
I dont see any entries that would exclude the new file
|
Added |
|
Hi! Sorry for the question from the audience, but is it (using Copilot to review PR's in ASF projects) possible at all? We discussed it in Apache cloudberry apache/cloudberry#1740 and came to the conclusion that it is not possible right yet ) I personally use Copilot, but using personal license. If you guys could use it maybe I could once again suggest enable Copilot ) |
|
@leborchuk I think you are right. @kevinjqliu just concluded this in https://lists.apache.org/thread/n2s6z7rt745cgftsb8j9yob0kc70cgny. Now we are just automating the Copilot code review on behalf of the PR author who has Copilot subscription. |
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Inspired by apache/iceberg-cpp#833
This will enable github to automatically request copilot review on PRs
where the author has access to copilot
## Are these changes tested?
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
4 participants
Rationale for this change
GitHub Copilot code review may help provide preliminary feedback on pull requests and reduce reviewer load while keeping human maintainers responsible for final review decisions.
What changes are included in this PR?
.asf.yamlAre these changes tested?
Yes.
.asf.yamlwas parsed successfully as YAML, andgit diff --checkpassed.Are there any user-facing changes?
No.