[to dev/1.3] Remove incorrect timeout reassignment after query planning#18196
[to dev/1.3] Remove incorrect timeout reassignment after query planning#18196shuwenwei wants to merge 1 commit into
Conversation
The context.setTimeOut() call in QueryExecution.start() mutated timeOut from the total timeout duration to the remaining time after planning. However, all consumers (checkTimeOutForQuery, cleanUpStaleQueries, timeout exception messages) assume timeOut holds the total duration. This caused stale query cleanup to trigger earlier than expected and incorrect deadline values in timeout error messages.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev/1.3 #18196 +/- ##
=============================================
+ Coverage 42.61% 43.50% +0.89%
+ Complexity 241 198 -43
=============================================
Files 3622 3630 +8
Lines 240790 243739 +2949
Branches 29341 29741 +400
=============================================
+ Hits 102602 106030 +3428
+ Misses 138188 137709 -479 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Nice catch — this looks right to me. I traced the One small thought: since several call sites recompute |



The context.setTimeOut() call in QueryExecution.start() mutated timeOut from the total timeout duration to the remaining time after planning. However, all consumers (checkTimeOutForQuery, cleanUpStaleQueries, timeout exception messages) assume timeOut holds the total duration. This caused stale query cleanup to trigger earlier than expected and incorrect deadline values in timeout error messages.
This was already fixed on the master branch by commit fddf0a6 as part of #15031.