Require the build checks before merging - #486
Merged
Merged
Conversation
Auto-merged Dependabot PRs landed on trunk with a failing build, because the `build` workflow was not a required check. Require all three platform jobs, so auto-merge waits for them. Assisted-By: Claude Fable 5 <noreply@anthropic.com>
ppkarwasz
force-pushed
the
fix/require-build-checks
branch
from
July 31, 2026 22:18
714d5dd to
8e47aa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the PMD ceilings fix (base:
fix/pmd-7-violation-ceilings); retarget totrunkonce that PR merges.Auto-merged Dependabot PRs landed on trunk with a failing build, because the
buildworkflow was not a required status check (only CodeQL was). This adds the three platform jobs of the reusable build workflow to the branch protection ruleset in.asf.yaml, so auto-merge waits for a green build:build / build (macos-latest)build / build (ubuntu-latest)build / build (windows-latest)The check names match the job names reported by the
buildworkflow on PRs (reusable workflow jobs report as<caller job> / <job> (<matrix>)).One caveat:
TestExecSource.testBatchTimeoutis known to be flaky on windows-latest, so requiring that job may occasionally need a re-run before auto-merge proceeds.