Skip to content

Adds maxRandomDelay configure to Rolling Appenders#4165

Merged
ramanathan1504 merged 2 commits into
2.xfrom
rollMaxRandomDelay
Jul 1, 2026
Merged

Adds maxRandomDelay configure to Rolling Appenders#4165
ramanathan1504 merged 2 commits into
2.xfrom
rollMaxRandomDelay

Conversation

@vy

@vy vy commented Jun 29, 2026

Copy link
Copy Markdown
Member

Fixes #4012 by reworking #4071, which superseded #4011.

Timeline

  1. In #4012, @OpenZYK asked to delay compression to mitigate I/O overload due to concurrent roll overs.
  2. @OpenZYK submitted #4011 to fix #4012. In reviews, @ppkarwasz suggested to delay the action chain instead of creating a new action to perform the delay. #4011 was abandoned and not merged.
  3. In #4071, @ramanathan1504 resurrected #4011, but did not follow @ppkarwasz's suggestion. #4071 is reviewed by @vy and merged.
  4. @OpenZYK kindly commented in #4011 to state that #4071 did not follow @ppkarwasz's suggestion.
  5. @vy submitted this PR to true #4071.

@vy vy added this to the 2.27.0 milestone Jun 29, 2026
@vy vy requested review from ppkarwasz and ramanathan1504 June 29, 2026 09:43
@vy vy self-assigned this Jun 29, 2026
@vy vy added appenders:Rolling Affects log file rolling functionality appenders Affects one or more Appender plugins labels Jun 29, 2026

@ramanathan1504 ramanathan1504 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this PR together to align with the original design @vy. My apologies for missing @ppkarwasz's feedback in #4071.
Verified and tested the updates. LGTM 👍🏾

@ramanathan1504 ramanathan1504 merged commit 7775e12 into 2.x Jul 1, 2026
10 checks passed
@ramanathan1504 ramanathan1504 deleted the rollMaxRandomDelay branch July 1, 2026 09:20
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Log4j pull request tracker Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appenders:Rolling Affects log file rolling functionality appenders Affects one or more Appender plugins

Projects

Development

Successfully merging this pull request may close these issues.

Proactively deferring compression can reduce disk I/O pressure.

2 participants