fix(docs): point <security-list> at the config key that exists - #1058
Open
potiuk wants to merge 1 commit into
Open
fix(docs): point <security-list> at the config key that exists#1058potiuk wants to merge 1 commit into
potiuk wants to merge 1 commit into
Conversation
Both places telling an agent how to resolve `<security-list>` named `mailing_lists.security`, which is not a key anywhere in the tree. The adopter manifest declares `security_list` under a `## Mailing lists` heading, so an agent following either instruction would look for a key that does not exist and be unable to resolve the placeholder. - `AGENTS.md` § Placeholder convention — the source column for `<security-list>`. - `skills/security-cve-allocate/SKILL.md` — the resolution block, where the sibling entries already use the flat form (`tracker_repo:`, `upstream_repo:`) and this one was the odd one out. Its arrow was also misaligned by a space against the entries around it; fixed while there. Verified against `projects/_template/project.md`: `security_list`, `private_list`, `users_list`, `dev_list`, `announce_list`, `commits_list` are the declared keys. Every other placeholder the table cites — `tracker_repo`, `upstream_repo`, `upstream_default_branch` — does resolve, so this was an isolated error rather than a pattern. Not touched, deliberately: `skills/security-issue-sync/github-advisory.md` uses `<security-team-list>` for the *org-level* advisory-admin address and `<security-list>` for the project list, in the same sentence. They are different addresses, so collapsing them would turn "email X, CC the project list" into "email X, CC X". The org-level address has no single agreed name — `<security-team-list>` here, `<asf-security-list>` in AGENTS.md, and `security_inbox.foundation_security_address` as the actual org-level config path — which wants deciding on its own, not guessing at inside a typo fix. Filed separately. Generated-by: Claude Code (Opus 5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<security-list>namedmailing_lists.security— a key that does not exist anywhere in the tree. The adopter manifest declaressecurity_list, under a## Mailing listsheading.AGENTS.md§ Placeholder convention and inskills/security-cve-allocate/SKILL.md, where the sibling entries already use the flat form and this one was the odd one out.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek runpasses on both changed filesprojects/_template/project.mdthatsecurity_listis the declared key, alongsideprivate_list,users_list,dev_list,announce_list,commits_listtracker_repo,upstream_repo, andupstream_default_branchall resolve in the template.mailing_lists.securitywas the only cited key with no definition, so this is an isolated error and not a patternmailing_listsappears nowhere in the repo except the two lines this PR correctsRFC-AI-0004 compliance
Linked issues
Follow-up to #1055. The related org-level naming problem is #1057.
Notes for reviewers (optional)
What I deliberately did not change, because it looks like the obvious tidy-up and is wrong:
skills/security-issue-sync/github-advisory.mduses<security-team-list>once, and it is tempting to normalise that to the registered<security-list>. It should not be. The two appear in the same instruction and mean different addresses:Collapsing them would turn that into "email X and CC X", quietly dropping the project security team from an advisory relay. I started to make that change and stopped after reading the surrounding sentence.
The underlying problem is that the org-level address has three names in the tree —
<security-team-list>,<asf-security-list>(ASF-branded, in a governance-agnostic framework), and the config pathsecurity_inbox.foundation_security_address— and none is registered in the placeholder table. That wants deciding deliberately rather than guessing at inside a typo fix, so it is #1057.