Skip to content

Cache projectsWithDeployExecution to fix O(N²) reactor scan #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnodet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cache projectsWithDeployExecution to fix O(N²) reactor scan #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.Map;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.stream.Collectors;

import org.apache.maven.api.Artifact;
import org.apache.maven.api.MojoExecution;
Expand Down Expand Up @@ -145,6 +146,8 @@ private enum State {
TO_BE_DEPLOYED
}

private static final String PROJECTS_WITH_DEPLOY_KEY = DeployMojo.class.getName() + ".projectsWithDeploy";

public DeployMojo() {}

private void putState(State state) {
Expand Down Expand Up @@ -195,7 +198,27 @@ public void execute() {
}

private boolean allProjectsMarked() {
return session.getProjects().stream().allMatch(p -> hasState(p) || !hasDeployExecution(p));
return getProjectsWithDeployExecution().stream().allMatch(this::hasState);
}

/**
* Returns the list of reactor projects that have a deploy execution, cached on first call.
* The list is invariant during a build and is stored in the first reactor project's plugin
* context to avoid recomputing it on every module invocation (O(N) total instead of O(N²)).
*/
@SuppressWarnings("unchecked")
private List<Project> getProjectsWithDeployExecution() {
List<Project> allProjects = session.getProjects();
if (allProjects.isEmpty()) {
return List.of();
}
Map<String, Object> ctx = session.getPluginContext(allProjects.get(0));
List<Project> cached = (List<Project>) ctx.get(PROJECTS_WITH_DEPLOY_KEY);
if (cached == null) {
cached = allProjects.stream().filter(this::hasDeployExecution).collect(Collectors.toList());
ctx.put(PROJECTS_WITH_DEPLOY_KEY, cached);
}
return cached;
}

private boolean hasDeployExecution(Project p) {
Expand Down
Loading