NIFI-16147 Removed unnecessary fully qualified names and implemented PMD rule UnnecessaryFullyQualifiedName - #11486
Merged
Merged
Conversation
…PMD rule UnnecessaryFullyQualifiedName
exceptionfactory
approved these changes
Jul 29, 2026
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Thanks @dan-s1, this covers a lot of files, but provides a helpful consistency across the project. +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16147
This PR first addressed the use of fully qualified names discovered by Intellij and those uncovered by the PMD rule
UnnecessaryFullyQualifiedName. TheUnnecessaryFullyQualifiedNameaims to address four categories:This PR as a result of fixing the aforementioned cases also fixed the seemingly in-congruent use of importing a class while also having static imports of variables in that class.
AzureStorageUtilsand statically importing some of its members in classesAbstractAzureDataLakeStorageProcessor,AzureDataLakeStorageFileResourceService,AzureStorageCredentialsControllerService_v12,FetchAzureBlobStorage_v12,FetchAzureDataLakeStorage,ListAzureBlobStorage_v12,ListAzureDataLakeStorageandPutAzureBlobStorage_v12Assertions,MockitoorArgumentMatchersand statically importing some of their methods.In the case of
Assertions,MockitoorArgumentMatchers, this PR made only static imports of the methods in these classes while forAzureStorageUtilsit dropped all the static imports.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation