industry/scpi: add unit parser config options#3556
Open
nightt5879 wants to merge 1 commit into
Open
Conversation
Expose scpi-parser unit support through explicit Kconfig options instead of raw CFLAGS. Map each option to the corresponding upstream USE_UNITS_* compile-time define, preserving the existing default unit set while allowing users to enable groups such as USE_UNITS_TIME. Signed-off-by: Nightt <87569709+nightt5879@users.noreply.github.com>
acassis
requested changes
Jun 24, 2026
acassis
left a comment
acassis
left a comment
Contributor
There was a problem hiding this comment.
@nightt5879 please update the SCPI documentation since you are working/testing it. Currently it is empty: https://nuttx.apache.org/docs/latest/applications/industry/scpi/index.html
Contributor
Author
|
Added the requested SCPI documentation in apache/nuttx#19207: apache/nuttx#19207 |
xiaoxiang781216
approved these changes
Jun 24, 2026
linguini1
reviewed
Jun 24, 2026
linguini1
left a comment
linguini1
left a comment
Contributor
There was a problem hiding this comment.
Did you try using the scpi tool after these changes?
Also why use $(call) in the Makefile?
xiaoxiang781216
pushed a commit
to apache/nuttx
that referenced
this pull request
Jun 24, 2026
Document the SCPI parser application, including source location, basic Kconfig options, and the unit parser options introduced by apache/nuttx-apps#3556. Signed-off-by: Nightt <87569709+nightt5879@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USE_UNITS_*compile-time define.USE_UNITS_TIME=1without raw CFLAGS injection.Fixes #3087
Testing
git diff upstream/master...HEAD --checkindustry/scpi/Kconfigwithkconfigliband verified all new unit symbols are present.