Skip to content

RATIS-2630. Netty data-stream shutdown leaks in-flight streams - #1539

Open
spacemonkd wants to merge 1 commit into
apache:masterfrom
spacemonkd:RATIS-2630
Open

RATIS-2630. Netty data-stream shutdown leaks in-flight streams#1539
spacemonkd wants to merge 1 commit into
apache:masterfrom
spacemonkd:RATIS-2630

Conversation

@spacemonkd

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

RATIS-2630. Netty data-stream shutdown leaks in-flight streams

  • On shutdown, DataStreamManagement.shutdown() only stopped the request/write executor pools.
  • In-flight streams left in the streams map were never drained, leaking their local DataStream resources (open file channels) and remote outputs on stop/restart.
  • Fixed by draining the map after the executors stop — reusing cleanUp(streams.keySet()) — and added StreamMap.keySet() to enumerate the remaining streams.
  • Added a TestDataStreamManagement case asserting an in-flight (header-only, no CLOSE) stream is released and unregistered after shutdown().

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-2630

How was this patch tested?

Tested using unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant