RATIS-2632. Apply backpressure on install-snapshot chunk loop - #1540
Open
spacemonkd wants to merge 1 commit into
Open
RATIS-2632. Apply backpressure on install-snapshot chunk loop#1540spacemonkd wants to merge 1 commit into
spacemonkd wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RATIS-2632. Apply backpressure on install-snapshot chunk loop
When the leader streams a snapshot to a lagging follower, the chunk send loop in GrpcLogAppender.installSnapshot() calls
snapshotRequestObserver.onNext(request)for every chunk without ever checkingCallStreamObserver.isReady().The append-entries path already checks isReady(), but the snapshot path does not, so it is possible that chunks are enqueued faster than the network can drain them.
While on the default path
INSTALL_SNAPSHOT_REQUEST_ELEMENT_LIMIT_DEFAULTis set to 8 soStreamObserverWithTimeoutapplies a request-response window, but since we allow setting the limit to 0, the semaphore can benulland cause:This is handled by having an explicit isReady() check, which causes minimal overhead on the default path (
element-limit=8) but handles the case when it might be set to 0.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2632
How was this patch tested?
Patch was tested via unit tests.