[Feature][Connector-V2] Add MQTT source connector#10935
Open
JAEKWANG97 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the contribution. I reviewed the latest head What problem this PR solves
Runtime chain I checkedCore reviewKey findings:
FindingsIssue 1: a long-lasting reconnect failure can silently stall the source instead of surfacing a task failure
Issue 2: the new tests do not cover connection-loss / reconnect-failure behavior
Compatibility
Tests / coverage
CI status
Conclusion: can merge after fixes
Overall, the feature direction makes sense and most of the source skeleton is in place. But for the current head, I would not merge yet because the reconnect/error state is still incomplete for a production streaming source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Add MQTT Source connector support for streaming jobs.
This PR adds:
This is part of #10753.
Does this PR introduce any user-facing change?
Yes.
Before this PR, the MQTT connector only supported the sink side in the current
devbranch, so users could publish SeaTunnel rows to an MQTT broker but could not configureMQTTas a source connector.After this PR, users can configure
MQTTas a source connector in streaming jobs to subscribe to an MQTT topic and read messages from an MQTT broker.Example:
This is a user-facing change in the unreleased
devbranch. It extends the existing MQTT connector by adding source-side support and documentation.How was this patch tested?
Added unit tests for:
Fork CI passed:
https://github.com/JAEKWANG97/seatunnel/actions/runs/26322480447
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.