Cover the silent-stall case (stacked on #12)#17
Merged
jirispilka merged 3 commits intoJul 21, 2026
Merged
Conversation
jirispilka
changed the title
jirispilka
force-pushed
the
claude/review-shepherd-issue-8-w7slof
branch
from
July 20, 2026 19:26
0b6b367 to
475f44a
Compare
jirispilka
changed the title
jirispilka
force-pushed
the
claude/shepherd-issue-8-mgxnft
branch
from
July 20, 2026 19:33
bae7c7b to
cfa61d2
Compare
Stacked on #12. #12 handles the file-is-on-disk-but-unnoticed case (missed notification). This adds the other direction: when the output file never appears because the dispatched agent died rather than running slowly, an absent file after several turns or a human check-in is a stall to surface and offer to re-dispatch, not another "still running" repeat. Extends #12's contract test with the new phrase. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014weQJCVrR4rakMvnSgMVm4
jirispilka
force-pushed
the
claude/review-shepherd-issue-8-w7slof
branch
from
July 20, 2026 19:33
475f44a to
05feee1
Compare
jirispilka
marked this pull request as ready for review
July 20, 2026 19:39
Pijukatel
reviewed
Jul 21, 2026
The silent-stall rule leaned on "if dispatch status exists ... report running only when explicitly active and stalled only when terminal" — as vague as the "after several turns" trigger it replaced (per @Pijukatel's review). Replace it with the honest, observable rule: an absent output file means only "not done" — report status unknown, offer to wait or re-dispatch, and never fabricate "still running"/"stalled" from turn count or a human check-in. Nets the skill from 500 to 499 lines and drops two now-redundant contract asserts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #12 — merge that first.
#12 makes the on-disk output file the completion signal, fixing #8's case where the file was already written but the orchestrator kept saying "still running." This covers the mirror case — the file is absent: with no liveness signal the orchestrator reports
status unknown; output not presentand offers to wait or re-dispatch, instead of repeating "still running" or inventing a "stalled" verdict.Addresses @Pijukatel's review — the vague "after several turns" trigger is gone. Status is only reported from what's on disk, never inferred from turn count or a human check-in.
Extends #12's contract test
test_dispatched_stage_completion_is_disk_based. Skill 499/500 lines; 99 tests pass.Part of #8