Skip to content

docs: Explorer skip for mechanical changes + defer to repo PR template#4

Merged
jirispilka merged 2 commits into
mainfrom
claude/apify-mcp-simplification-4hehpt
Jul 14, 2026
Merged

docs: Explorer skip for mechanical changes + defer to repo PR template#4
jirispilka merged 2 commits into
mainfrom
claude/apify-mcp-simplification-4hehpt

Conversation

@jirispilka

@jirispilka jirispilka commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Ad-hoc — two shepherd-generality tweaks surfaced by a /shepherd-evaluate pass on a real run. Both are SKILL.md text only.

What changed

  1. Explorer skip (§3 Design → Draft): the explorer stage may be skipped even at medium/large tier when the verify fact-check already provides a file-level map and the change is mechanical (pure deletion, rename, inlining), recorded in _progress.md.
  2. Defer to a repo PR template (§9 Finish): if the repo has a PR template, mirror its headings and fill them from the run; otherwise fall back to the plain What / How / Alternatives body. Keeps shepherd repo-agnostic while honoring each repo's own PR convention.

Why

Both codify judgments the orchestrator was otherwise making ad hoc. On a mechanical run the fact-check already locates every symbol, so the explorer only reproduced it. And hardcoding the PR-body format ignored templates a repo provides — now that's the fallback, not the rule.

What I'm unsure about

Nothing outstanding — the finish-step change was merged with main's concurrent edits to the same section (the Closes #N closing-keyword guidance is preserved). The contract test that pins the plain-body wording still passes.

Proof it works

python -m pytest tests/ → 84 passed locally (the orchestrator-contract suite that pins these SKILL.md invariants). Rebased onto current main; conflict resolved.


  • Single concern — two closely-related SKILL.md generality tweaks; no unrelated changes
  • Clean diff — SKILL.md text only, +11/-5
  • I reviewed my own diff before requesting review

claude added 2 commits July 14, 2026 09:49
The design phase always dispatches the explorer at medium/large tier, but
when the verify fact-check already contains a file-level map and the change
is mechanical (pure deletion, rename, inlining), the explorer pass only
duplicates it. Add a carve-out so it can be skipped in that case, recorded
in _progress.md — codifying a judgment the orchestrator otherwise makes ad
hoc.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R4WLGFUppcs4tNxoNsJP2x
Step 9 hardcoded the PR body as "What we're solving / How / Alternatives
and nothing else", which ignored any template a repo provides. Make that
the fallback: if the repo has a PR template, mirror its headings and fill
them from the run; otherwise use the plain default. Keeps shepherd
repo-agnostic while honoring each repo's own PR convention.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R4WLGFUppcs4tNxoNsJP2x
@jirispilka
jirispilka force-pushed the claude/apify-mcp-simplification-4hehpt branch from 9a72bb3 to eba90f8 Compare July 14, 2026 09:50
@jirispilka jirispilka changed the title docs: Skip explorer for mechanical changes with a verify map docs: Explorer skip for mechanical changes + defer to repo PR template Jul 14, 2026
@jirispilka
jirispilka merged commit 20e889f into main Jul 14, 2026
2 checks passed
@jirispilka
jirispilka deleted the claude/apify-mcp-simplification-4hehpt branch July 14, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants