Fix orchestrator loopholes, zero-findings convergence, and compress the skill spec#6
Conversation
…fying conditions for design feedback
…ocumentation and tests
…tation for iteration processes
…n for commit behavior
…s and revise related test assertions
…ocumentation on session handling
…entation for review phases
…ss and update related test assertions
…d update related descriptions
…in configuration files
Pijukatel
left a comment
There was a problem hiding this comment.
Seems ok, but I realized that the step referencing seems a little bit loose. What is making the model correctly understand that the steps mentioned are from the top-level flow and not some substeps inside some smaller task? Maybe I just missed the part that makes it clear
For example, step 2 could be several things in different contexts:
### 2. Verify... <- this is the desired target, right?
2. On iteration 1, before...
2. Commit only the run...
2. Fresh run: require a non-empt...
Great point! Nothing guaranteed that; fixed in the latest commits: every cross-reference now names its target ("step 4 (Design gate)"), each top-level heading declares its _state.json phase |
What we're solving
A full scrutiny of the shepherd skill found state-machine gaps, doc contradictions, and under-specified plumbing that a literal orchestrator would get wrong.
Changes
Pipeline logic
_design_feedback.mdwhenever it exists — verify-stage human decisions are no longer invisible to the first draftphase=done; "fix the findings" is an explicit reopeniter-1/predirty.txt, kept out ofdiff.patchand the final commitphase=create-prwithout the marker re-establishes fulfillment before the confirmiter-N— evidence is never overwritteniter-N/test-results.txt;fulfillmentadded to model tieringDocs & config
config.json/registry.jsonare committable team config; shepherd itself never stages.shepherd/pathsponytail-review/SKILL.md→ENGINE.md(no stray slash command); shallow-merge warning in config docs; deadhead_shafield removedSpec size
SKILL.mdcompressed 450 → 424 lines with rule-for-rule semantic verification (three drifts found and restored)🤖 Generated with Claude Code