Add PriorityClass support for pod scheduling and preemption#749
Open
miuponn wants to merge 15 commits into
Open
Add PriorityClass support for pod scheduling and preemption#749miuponn wants to merge 15 commits into
miuponn wants to merge 15 commits into
Conversation
miuponn
changed the title
…t interface Added getter
leochr
reviewed
Jun 1, 2026
| // +operator-sdk:csv:customresourcedefinitions:order=30,type=spec,displayName="Host Aliases" | ||
| HostAliases []corev1.HostAlias `json:"hostAliases,omitempty"` | ||
|
|
||
| // Name of the PriorityClass for the pod. |
Member
There was a problem hiding this comment.
Suggestion: Name of the PriorityClass for the application pods.
|
|
||
| pts.Spec.Tolerations = ba.GetTolerations() | ||
|
|
||
| pts.Spec.PriorityClassName = "" |
Member
There was a problem hiding this comment.
This could be added in an 'else' block to avoid always setting to empty (even when PriorityClass is defined).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?:
PR for #367
priorityClassNamefield toRuntimeComponentSpecto allow users to assign k8s PriorityClass to operator-managed podspriorityClassNameto the Knative service spec when createKnativeService is enabledPR for OLO WLO
Does this PR introduce a user-facing change?
CHANGELOG.mdWhich issue(s) this PR fixes: