Accept providerNamespace on createRepository to create in a GitLab group#12970
Merged
Conversation
Contributor
Greptile SummaryAdds namespace-aware repository creation by forwarding an optional provider namespace through the VCS endpoint and GitLab OAuth client, while preserving no-op compatibility for GitHub and Gitea OAuth clients.
Confidence Score: 5/5The PR appears safe to merge because no additional blocking failure eligible for this follow-up review remains. No blocking failure remains beyond the issues already covered by the previous review threads. Important Files Changed
Reviews (2): Last reviewed commit: "Accept providerNamespace on createReposi..." | Re-trigger Greptile |
Mirrors the listRepositories fix: without this, a GitLab user with groups could only ever create new repos in their personal namespace, since createRepository always resolved the owner from the installation itself.
HarshMN2345
force-pushed
the
feat/vcs-gitlab-list-namespaces
branch
from
July 24, 2026 07:29
8a98ec4 to
f086253
Compare
✨ Benchmark resultsComparing
Per-scenario breakdown & investigation detailsMetrics below reflect the current branch (after). Δ P95 compares against the base.
Top API waits (after)
|
Meldiron
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The namespaces endpoint and
listRepositoriesnamespace support (merged in #12951) let you browse a GitLab group's repos, butcreateRepositorystill always resolved the owner from the installation itself -- so a GitLab user with groups had no way to create a new repo inside a group, only in their personal namespace.This mirrors the
listRepositoriesfix: adds an optionalproviderNamespaceparam tocreateRepository, threaded through toOAuth2Gitlab::createRepository()as GitLab'snamespace_id. Also widensGithub/GiteaOAuth2createRepository()signatures with the same optional (no-op) param so the call site doesn't need a provider-specific branch.Test plan
composer format && composer analyze(done locally, clean)providerNamespaceset to a GitLab group, verify it lands in the group not the personal namespaceproviderNamespace, verify unchanged personal-namespace behavior for GitHub/Gitea/GitLab