Skip to content

explicitly install poetry-plugin-export#18

Open
dustinblack wants to merge 1 commit into
mainfrom
poetry-plugin-export
Open

explicitly install poetry-plugin-export#18
dustinblack wants to merge 1 commit into
mainfrom
poetry-plugin-export

Conversation

@dustinblack

Copy link
Copy Markdown
Member

Changes introduced with this PR

Responding to warning from poetry:

Warning: poetry-plugin-export will not be installed by default in a future version of Poetry.
In order to avoid a breaking change and make your automation forward-compatible, please install poetry-plugin-export explicitly. See https://python-poetry.org/docs/plugins/#using-plugins for details on how to install a plugin.

By contributing to this repository, I agree to the contribution guidelines.

@dustinblack dustinblack requested a review from a team August 5, 2025 09:52

@dbutenhof dbutenhof left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure; but I always thought it was weird to "manage dependencies" using poetry but then go out of the way to "install dependencies" using pip anyway. Why not just use poetry install instead of worrying about exporting? (That's what we did for cpt-dashboard instead of adjusting to the new export plugin.)

@webbnh webbnh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing Dave's sentiment, apparently you can also declare the plug-in as a dependency, which might produce an easier-to-maintain result.

If you felt so inclined, you could add a default value (e.g., latest) to the ARG declaration, which would quiet the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants