Fix too-many-statements-in-try-clause violations#4648
Open
codefiles wants to merge 1 commit into
Open
Conversation
svartkanin
reviewed
Jul 21, 2026
| debug(f'failed to enable wpa_supplicant: {err}') | ||
| return False | ||
|
|
||
| result = self._wpa_cli('status') # if it it's running it will blow up |
Collaborator
There was a problem hiding this comment.
If the comment is still valid than calling status will throw an exception so it should be tried with return false no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff check --previewgives errors on these.https://docs.astral.sh/ruff/rules/too-many-statements-in-try-clause/