Skip to content

ch13726a: Remove MIPI_DSI_MODE_VIDEO_BURST#9891

Open
kay-lambdadelta wants to merge 1 commit into
armbian:mainfrom
kay-lambdadelta:main
Open

ch13726a: Remove MIPI_DSI_MODE_VIDEO_BURST#9891
kay-lambdadelta wants to merge 1 commit into
armbian:mainfrom
kay-lambdadelta:main

Conversation

@kay-lambdadelta
Copy link
Copy Markdown
Contributor

@kay-lambdadelta kay-lambdadelta commented May 25, 2026

Description

Remove MIPI_DSI_MODE_VIDEO_BURST, like the eventually to be upstream driver.

With the flag, severe screen tearing often occurs.

How Has This Been Tested?

This was tested on my own Retroid Pocket 5

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Summary by CodeRabbit

  • New Features
    • Added support for DDIC CH13726A display panel with brightness control and configurable display modes.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b349760b-9382-4f9d-b1bb-004a82426265

📥 Commits

Reviewing files that changed from the base of the PR and between 9bd9bcd and 9a147ba.

📒 Files selected for processing (1)
  • patch/kernel/archive/sm8250-6.19/0065-drm-panel-Add-DDIC-CH13726A-panel-Signed-off-by-Tegu.patch

📝 Walkthrough

Walkthrough

This patch adds a new DDIC CH13726A DSI panel driver to the DRM framework. It introduces build configuration via Kconfig and Makefile entries, implements a complete panel driver with power management, GPIO reset, regulator control, backlight support, and two display modes, and adjusts DSI mode flags to exclude VIDEO_BURST mode.

Changes

CH13726A Panel Driver Support

Layer / File(s) Summary
Build system integration
drivers/gpu/drm/panel/Kconfig, drivers/gpu/drm/panel/Makefile
New DRM_PANEL_DDIC_CH13726A Kconfig symbol and Makefile build rule enable the panel driver to be compiled.
Driver implementation — DSI mode flags
drivers/gpu/drm/panel/panel-ddic-ch13726a.c
DSI mode_flags initialized without MIPI_DSI_MODE_VIDEO_BURST, retaining MIPI_DSI_MODE_VIDEO and MIPI_DSI_CLOCK_NON_CONTINUOUS.
Patch metadata cleanup
patch/kernel/archive/sm8250-6.19/0065-drm-panel-Add-DDIC-CH13726A-panel-Signed-off-by-Tegu.patch
Trailing Armbian footer lines removed from patch file.

🎯 2 (Simple) | ⏱️ ~12 minutes

🐰 A panel driver hops into the fold,
With DSI signals bright and bold,
Burst mode removed for clarity's sake,
New backlight paths the system will take,
CH13726A shines with every flick!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly references the main technical change: removing MIPI_DSI_MODE_VIDEO_BURST from the CH13726A panel driver, which aligns with the patch content and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size/small PR with less then 50 lines 05 Milestone: Second quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels May 25, 2026
@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label May 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants