feat: add fedcm_login support for Google One Tap / FedCM in Universal Login#1407
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1407 +/- ##
=======================================
Coverage 80.19% 80.19%
=======================================
Files 153 153
Lines 7119 7119
Branches 1573 1573
=======================================
Hits 5709 5709
Misses 760 760
Partials 650 650 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
harshithRai
reviewed
Jun 23, 2026
Comment on lines
+406
to
+417
| fedcm_login: { | ||
| type: ['object', 'null'], | ||
| description: 'Configuration for FedCM (Federated Credential Management) login', | ||
| properties: { | ||
| google: { | ||
| type: 'object', | ||
| properties: { | ||
| is_enabled: { type: 'boolean' }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, |
Contributor
There was a problem hiding this comment.
As per the description, google is required when fedcm_login is set. But the schema doesn't enforce this; fedcm_login: {} and fedcm_login: { google: {} } both pass validation based on current code.
Similar fields like token_quota handle this with required: ['client_credentials'].
Maybe we should add required: ['google'] under fedcm_login and required: ['is_enabled'] under google?
Contributor
Author
There was a problem hiding this comment.
Addressed and updated
harshithRai
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Adds fedcm_login to the client JSON schema to support the Google One Tap / FedCM (Federated Credential Management) feature in New Universal Login.
Schema addition (
src/tools/auth0/handlers/clients.ts):No additional handler changes were required - fedcm_login is a plain nested object with no ID-to-name mapping, no special serialization, and is valid on both create and
update operations.
📚 References
🔬 Testing
Unit tests (
test/tools/auth0/handlers/clients.tests.js):Manual end-to-end against dev-ankita-t.us.auth0.com (feature flag enable_google_one_tap_ul enabled):
📝 Checklist