fix: allow Auth0 lowercase template variables to pass keyword placeholder validation#1408
Open
harshithRai wants to merge 1 commit into
Open
fix: allow Auth0 lowercase template variables to pass keyword placeholder validation#1408harshithRai wants to merge 1 commit into
harshithRai wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1408 +/- ##
=======================================
Coverage 80.19% 80.19%
=======================================
Files 153 153
Lines 7119 7119
Branches 1573 1573
=======================================
Hits 5709 5709
Misses 760 760
Partials 650 650 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auth0 SMS connections support native template variables like
@@password@@that were being incorrectly flagged as unresolved keyword placeholders, causing imports to fail.🔧 Changes
[A-Z0-9_]), aligning with the established deploy-cli keyword convention (@@MY_KEY@@,##MY_SECRET##). Lowercase Auth0-native template variables are no longer flagged as unresolved.📚 References
Auth0 SMS template variables documentation
🔬 Testing
Unit tests:
test/tools/utils.test.jsto include a lowercase@@...@@value, confirming it no longer throwsManual end-to-end:
@@password@@importfailed withUnresolved placeholder(s) found in connections: "options.template": @@password@@importcompleted successfully - SMS connection updated without error##CONNECTIONS_OAUTH2_SECRET##) still correctly throw an error📝 Checklist