i18n: add too_many_attempts key to passwordless error section across all locales - #2839
Open
ankita10119 wants to merge 1 commit into
Open
i18n: add too_many_attempts key to passwordless error section across all locales #2839ankita10119 wants to merge 1 commit into
ankita10119 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds the too_many_attempts error message to the error.passwordless section in all 44 locale files, bringing v13 to parity with master.
Also relaxes the i18n sanitizer test assertion from an exact string match to regex matchers, making it resilient to attribute ordering differences across sanitizer versions.
No API or UI changes.
References
Testing
Existing i18n test suite passes. The sanitizer test (should sanitize the input and not allow for javascript to be passed through) was updated to verify attributes individually rather than asserting a fixed output string.
Checklist