refactor: upgrade react-transition-group v2 to v4 and migrate string refs to createRef - #2840
Open
ankita10119 wants to merge 1 commit into
Open
refactor: upgrade react-transition-group v2 to v4 and migrate string refs to createRef#2840ankita10119 wants to merge 1 commit into
ankita10119 wants to merge 1 commit into
Conversation
…refs to createRef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Upgrades react-transition-group from
^2.2.1to^4.4.5. RTG v4 removes internal use of the deprecatedReactDOM.findDOMNode, requiring an explicitnodeRefprop onCSSTransition. This in turn drove a full migration from legacy string refs (this.refs.*) andReactDOM.findDOMNodecalls toReact.createRef()across the UI layer.Components changed:
ui/box/chrome.jsx-CSSTransitiongains nodeRef props; screen, auxiliary, and globalMessage refs converted to createRefui/box/container.jsx-this.refs.chrome→this.chromeRefui/box/header.jsx-getDOMNodeusesthis.headerRef.currentinstead offindDOMNode(this)ui/box/multisize_slide.js-this.refs[key]replaced with achildRefsmap ofcreateRefinstancesui/list.jsx-this.refs.highlightedandfindDOMNoderemovedthis.refs.input→this.inputRef.currentAlso removes the unused events dev dependency.
References
Testing
All 401 existing tests pass. Visual/animation behaviour should be verified manually, particularly the slide transition between screens and the auxiliary pane animation.
Checklist